-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inventorize disks in eryph storage independently of catlets #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherMann
force-pushed
the
pull/disk-inventory
branch
2 times, most recently
from
January 16, 2025 10:32
8c1784a
to
3c195d0
Compare
* Improve output
ChristopherMann
force-pushed
the
pull/disk-inventory
branch
from
January 21, 2025 16:37
00f4611
to
5799bfc
Compare
* Only mark disks as deleted
* Add logging
Quality Gate passedIssues Measures |
fw2568
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the inventory of disks in the eryph storage. Disks are now inventoried independently of catlets and the underlying file systems are monitored for changes.
Additionally, this PR contains a rewrite of the
DestroyResourcesSaga
which fixes a timing issues that caused the deletion of projects to somtimes fail.Closes #211