Skip to content

Commit

Permalink
source-intercom-native: remove unneeded counts from conversations a…
Browse files Browse the repository at this point in the history
…nd `tickets`

After the change in commit 7702e44 to checkpoint after every page, the counts in `conversations` and `tickets` no longer served any purpose. I missed removing them in that earlier commit, so they're being removed now.
  • Loading branch information
Alex-Bair committed Feb 24, 2025
1 parent 6e6f221 commit 77b4cd3
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions source-intercom-native/source_intercom_native/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,6 @@ async def fetch_tickets(
url = f"{API}/tickets/search"
body = _generate_conversations_or_tickets_search_body(start, end)

count = 0

while True:
response = TicketsSearchResponse.model_validate_json(
await http.request(log, url, "POST", json=body)
Expand Down Expand Up @@ -294,7 +292,6 @@ async def fetch_tickets(

if ticket.updated_at > start:
yield ticket
count += 1

if response.pages.next is None:
yield _s_to_dt(last_seen_ts)
Expand All @@ -318,8 +315,6 @@ async def fetch_conversations(
url = f"{API}/conversations/search"
body = _generate_conversations_or_tickets_search_body(start, end)

count = 0

while True:
response = ConversationsSearchResponse.model_validate_json(
await http.request(log, url, "POST", json=body)
Expand Down Expand Up @@ -349,7 +344,6 @@ async def fetch_conversations(

if conversation.updated_at > start:
yield conversation
count += 1

if response.pages.next is None:
yield _s_to_dt(last_seen_ts)
Expand Down

0 comments on commit 77b4cd3

Please sign in to comment.