Fix: Make _airtable_id not nullable, since it's a primary key

estuary · Jan 18, 2024 · c0fc9ea · c0fc9ea
1 parent 0db88f7
commit c0fc9ea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/source-airtable/source_airtable/source_airtable/schema_helpers.py b/source-airtable/source_airtable/source_airtable/schema_helpers.py
@@ -87,7 +87,8 @@ def clean_name(name_str: str) -> str:
     @staticmethod
     def get_json_schema(table: Dict[str, Any]) -> Dict[str, str]:
         properties: Dict = {
-            "_airtable_id": SchemaTypes.string,
+            # This is primary key, shouldn't be null
+            "_airtable_id": {"type": "string"},
             "_airtable_created_time": SchemaTypes.string,
             "_airtable_table_name": SchemaTypes.string,
         }

diff --git a/...table/tests/snapshots/source_airtable_tests_test_snapshots__discover__capture.stdout.json b/...table/tests/snapshots/source_airtable_tests_test_snapshots__discover__capture.stdout.json
@@ -11,10 +11,7 @@
       "additionalProperties": true,
       "properties": {
         "_airtable_id": {
-          "type": [
-            "null",
-            "string"
-          ]
+          "type": "string"
         },
         "_airtable_created_time": {
           "type": [