materialize-mongodb: remove _id property from loaded docs #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the `_id` property before returning loaded documents. This is to
prevent that property from causing schema validation errors for collections
that use a top level `reduce: { strategy: merge }`.
psFried
force-pushed
the
phil/mongo-redact-id
branch
from
f07b4e4 to
fcfffd9
Compare
|
I had previously created this materialization to reproduce this issue. I then updated that materialization to use the image from this PR build, and it started working correctly again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
_idproperty before returning loaded documents. This is to prevent that property from causing schema validation errors for collections that use a top levelreduce: { strategy: merge }.This change is