materializations: a couple of validation fixes #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or float64 We used to create number columns as "bignumeric", so allowing "bignumeric" for these columns allows for backward compatibility. See #859.
…keyword Users may wish to pre-create indices with specific mappings as keywords instead of text, or alter their mappings after the fact.
mdibaiee
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A couple of simple fixes I found from a survey of existing materializations:
For
materialize-bigquery, we used to create number columns as "bignumeric", so allowing "bignumeric" for these columns allows for backward compatibility.For
materialize-elasticsearch, there are cases where users have pre-created or modified mappings for fields we would create astextto instead bekeyword. This seems like a reasonable thing to support, so that is being allowed by validation.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is