fix: Python packages broke when introducing source-hubspot, this fixes all python packages
#1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xes all python packages
jshearer
force-pushed
the
fix/python_packages
branch
from
e630e12 to
584d5d6
Compare
jshearer
commented
Feb 16, 2024
| @@ -59,7 +59,6 @@ WORKDIR /connector | |||
| COPY --from=builder /builder/connector ./$CONNECTOR_NAME | |||
| COPY --from=builder /builder/python ./python | |||
|
|
|||
| ENV PYTHONPATH="/connector/$CONNECTOR_NAME" | |||
There was a problem hiding this comment.
This is the change that broke things -- all python packages (except source-hubspot) are now complaining that
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/connector/source-airtable/__main__.py", line 2, in <module>
from source_airtable import SourceAirtable
ImportError: cannot import name 'SourceAirtable' from 'source_airtable' (unknown location)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Because
source-pythondoesn't use a sub-package like all other python packages do, it needed different treatment. This different treatment broke everything, so this PR undoes it and fixes the problem a different way.tl;dr, the upper
source-pythonpackage was a special namespace package, and Airbyte CDK was using a specific function to load thespec.yamlfile that doesn't work on namespace packages, apparently. So the fix ended up being to movespec.yamlup a directory and add a blank__init__.pytosource-pythonto make it not a namespace package... k ¯_(ツ)_/¯This change is