source-*-batch: No longer run discovery during Validate #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have reason to believe that running discovery is causing publication failures for at least one user whose database has a lot of stuff in it, and there's no strong need to run the full discovery process as part of validation -- it was just an easy-to-implement way of getting a bunch of sanity checking done all at once. So the call to `Discover()` is removed, in favor of merely parsing the config and connecting to the database. The database connect function has been modified in each connector so that it now runs a no-op `SELECT true;` query, to make sure that we don't introduce some sort of subtle failure mode where validation passes but the user doesn't actually have the ability to execute queries at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have reason to believe that running discovery is causing publication failures for at least one user whose database has a lot of stuff in it, and there's no strong need to run the full discovery process as part of validation -- it was just an easy-to-implement way of getting a bunch of sanity checking done all at once.
So the call to
Discover()is removed, in favor of merely parsing the config and connecting to the database. The database connect function has been modified in each connector so that it now runs a no-opSELECT true;query, to make sure that we don't introduce some sort of subtle failure mode where validation passes but the user doesn't actually have the ability to execute queries at all.This change is