source-hubspot-native: conditionally discover email_events binding
#2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all HubSpot accounts have enough permissions to access the endpoint for the `email_events` binding. This binding is now discovered only if we can successfully hit the associated endpoint without a permissions error. The permissions checking code isn't very reusable, but it can be refactored later if/when the connector needs to conditionally discover other bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Not all HubSpot accounts have enough permissions to access the endpoint for the
email_eventsbinding. This binding is now discovered only if we can successfully hit the associated endpoint without a permissions error.The permissions checking code isn't very reusable, but it can be refactored later if/when the connector needs to conditionally discover other bindings.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested on a local stack. Confirmed that
email_eventsis discovered if a user's HubSpot account has the appropriate permissions, andemail_eventsis not discovered if the user's HubSpot account does not have the appropriate permissions.Existing captures that have
email_eventsenabled but whose tokens do not have the appropriate permissions should either disable theemail_eventsbinding or perform discoveries to removeemail_eventsas a possible binding. The latter will likely be handled by auto-discovers.The discover snapshot change is expected since the order of the bindings returned by
all_resourceshas changed (email_eventsis now at the end of the list).This change is