source-facebook-marketing: remove wish_bid from ads_insights.json
#2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple production tasks have encountered errors where any async job requesting the `wish_bid` field have started consistently failing on Facebook's side. Async jobs that do not request `wish_bid` still succeed. Removing `wish_bid` from the `ads_insights.json` schema file also removes it from the list of fields requested from async jobs, and tasks that were previously failing should now work fine. It's unclear to me what changed that causes async jobs requesting the `wish_bid` field to fail, and maybe it can be added back later if there's motivation to investigate further & determine root cause.
Alex-Bair
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Multiple production tasks have encountered errors where any async job requesting the
wish_bidfield have started consistently failing on Facebook's side. Async jobs that do not requestwish_bidstill succeed.Removing
wish_bidfrom theads_insights.jsonschema file also removes it from the list of fields requested from async jobs, and tasks that were previously failing should now work fine. It's unclear to me what changed that causes async jobs requesting thewish_bidfield to fail, and maybe it can be added back later if there's motivation to investigate further & determine root cause.Discover snapshot changes are expected since
wish_bidhas been removed from theads_insightsstream and its children.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested on a local stack. Confirmed tasks that were previously failing due to failed async jobs during the
ads_insightsstream (and children) now completed & work fine.Existing collections that contain documents with
wish_bidvalues do not haveadditionalPropertiesexplicitly set tofalse, so the now extrawish_bidfield should not cause validation failures when reading from those collections.This change is