source-hubspot-native: use v3 of the owners API #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v2 owners API has been deprecated and actually doesn't even work on newer accounts. We need to use the v3 owners API instead of the v2 owners API to prevent issues with newer HubSpot accounts. The API output is slightly different between the v3 and the v2 API, but since this is a snapshot stream anyway and very low volume for our current use cases, I'm not anticipating that being a huge issue. We could build in some kind of backward compatibility to make the v2 and v3 output more the same, or have captures that are able to use the v2 API or something like that, but I don't think that is worth the long-term maintenance cost we would take on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The v2 owners API has been deprecated and actually doesn't even work on newer accounts. We need to use the v3 owners API instead of the v2 owners API to prevent issues with newer HubSpot accounts.
The API output is slightly different between the v3 and the v2 API, but since this is a snapshot stream anyway and very low volume for our current use cases, I'm not anticipating that being a huge issue.
We could build in some kind of backward compatibility to make the v2 and v3 output more the same, or have captures that are able to use the v2 API or something like that, but I don't think that is worth the long-term maintenance cost we would take on.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is