Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source iterate: new connector #2316

Merged
merged 2 commits into from
Jan 31, 2025
Merged

source iterate: new connector #2316

merged 2 commits into from
Jan 31, 2025

Conversation

Alex-Bair
Copy link
Member

@Alex-Bair Alex-Bair commented Jan 31, 2025

Description:

This is a minimal connector for IterateHQ's API (although there aren't many other endpoint in this API). The requirements were for surveys and survey_responses to be full refresh. We might be able to make survey_responses incremental (client-side) if there's motivation to do so since each survey has a list of updated_at datetime strings within it. But the API documentation around what these updated_at lists actually mean is non-existant & there's no clear need to make this stream incremental, so I'm punting that for now. After we see what the data actually looks like, we could consider making that improvement if it's warranted.

Closes #2270

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

Documentation will need created for this connector.

Notes for reviewers:

Tested on a local stack. Confirmed:

  • Both streams capture data.
  • Both surveys and survey_responses can be materialized into a dockerized Postgres instance.

This change is Reviewable

This is a minimal connector for IterateHQ's API (although there aren't
many other endpoint in this API). The requirements were for `surveys`
and `survey_responses` to be full refresh. We might be able to make
`survey_responses` incremental (client-side) if there's motivation to do
so since each survey has a list of `updated_at` datetime strings within
it. But the API documentation around what these `updated_at` lists
actually mean is non-existant & there's no clear need to make this stream
incremental, so I'm punting that for now. After we see what the data
actually looks like, we could consider making that improvement if it's
warranted.
@Alex-Bair Alex-Bair marked this pull request as ready for review January 31, 2025 00:12
@Alex-Bair Alex-Bair requested a review from a team January 31, 2025 00:12
@Alex-Bair Alex-Bair changed the title Bair/source iterate source iterate: new connector Jan 31, 2025
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dyaffe dyaffe merged commit 85638f0 into main Jan 31, 2025
79 of 84 checks passed
@Alex-Bair Alex-Bair deleted the bair/source-iterate branch February 19, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new connector: source-iterate
3 participants