source-zendesk-support-native: misc fixes #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a start date before the epoch (i.e. a negative timestamp) in requests to Zendesk result in a 400 error. Validating the start date isn't before the epoch should avoid these errors.
…ating through a tickets response With the change to streaming incremental export responses, ticket child resource streams ended up trying to maintain a long-lived tickets response while fetching child resources for each ticket within the response. This caused `aiohttp` TimeoutErrors. To get around this, we fetch all tickets in a single response then fetch child resources for those tickets.
…ponses in `ticket_metrics` Side loading metric sets can cause Zendesk's API to take a while to respond. Using the max page size of 1,000 has caused the intermediate routers/gateways to return a 504 response. This commit reduces the page size for `ticket_metrics` to 500 to mitigate these 504 responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes a few miscellaneous fixes for bugs in
source-zendesk-support-native. These fixes include:start_dateis at least the epoch so converting to a timestamp always results in a non-negative number.aiohttpTimeoutErrors for ticket child streams by not trying to maintain a long-lived streaming response when fetching parent tickets.ticket_metricsto reduce how much processing Zendesk must do for a response & avoid intermediate gateways from sending us 504 timeout responses.i. We might want to make this configurable later or surface 5xx responses through our CDK at some point, but that level of effort isn't necessary right now.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested on a local stack. Confirmed:
ticket_commentsandticket_audits, no longer experienceTimeoutErrorsfromaiohttp.ticket_metricsrequests complete successfully & avoid 504 responses when using a smaller page size.This change is