connectors: update schemagen #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the `invopop/jsonschema` package to the latest. Although not used directly here, this will make doing things like `oneOfs` in generated schemas easier (although still not really "easy"), and I plan on doing that in later work. Since this update is an almost-entirely mechanical update that touches just about every connector's test snapshots, I wanted to split it out as a separate PR.
Alex-Bair
approved these changes
Feb 19, 2025
| sf "github.com/snowflakedb/gosnowflake" | ||
| orderedmap "github.com/wk8/go-ordered-map/v2" |
There was a problem hiding this comment.
What's the reason for switching from github.com/iancoleman/orderedmap to github.com/wk8/go-ordered-map/v2?
There was a problem hiding this comment.
invopop/jsonschema changed to using that library for the ordered map that represents its Properties, so we have to use it too in cases where we manipulate the Properties directly, such as building up a schema manually like we do in this file and a few other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates the
invopop/jsonschemapackage to the latest.Although not used directly here, this will make doing things like
oneOfsin generated schemas easier (although still not really "easy"), and I plan on doing that in later work.Since this update is an almost-entirely mechanical update that touches just about every connector's test snapshots, I wanted to split it out as a separate PR.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is