source-bigquery-batch: Code health improvements #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we've now done with batch MySQL and PostgreSQL, this commit adds a fairly extensive list of new test cases exercising most BigQuery column types and a variety of edge-cases around cursor handling.
This modifies source-bigquery-batch with the new batch SQL behavior where discovered resources omit a query template by default and instead just include the schema/table name and expect the connector to supply the default polling query. There's no urgent need for this feature in source-bigquery-batch but it's good to make things consistent across all of the batch SQL capture connectors.
Updates test snapshots and fixes some tests which weren't fully reproducible before.
willdonnelly
force-pushed
the
wgd/bigquery-batch-code-health-20250218
branch
from
d50d8a1 to
4991b74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As with source-postgres-batch and source-mysql-batch, this PR is mostly a bunch of test suite improvements along with the change to omit query templates from discovered bindings by default in favor of letting the connector pick the appropriate default query when unspecified.
This change is