source-mixpanel-native: increase funnels date window size
#2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the fix made to `annotations` in 8284cbc to the `funnels` stream. The connector has to send at least one API request for each funnel, and for users with hundreds of funnels, this will a minimum take multiple hours. If the connector uses a small date window size & makes more than a single request per funnel, then it's possible for `funnels` to never complete in 24 hours. Since each funnel typically only has KB of data, we can force `funnels` to make a single request per funnel by using a very large date window size.
Alex-Bair
deleted the
bair/source-mixpanel-native-funnels-window-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This implements the fix made to
annotationsin #2389 to thefunnelsstream. The connector has to send at least one API request for each funnel, and for users with hundreds of funnels, this will at minimum take multiple hours. If the connector uses a small date window size & makes more than a single request per funnel, then it's possible forfunnelsto never complete in 24 hours.Since each funnel typically only has KB of data, we can force
funnelsto make a single request per funnel by using a very large date window size.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested on a local stack. Confirmed that a single request is made per funnel even when the configured date window size is small (1 day).
This change is