Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-stripe-native: handle another 404 for missing child resources #2448

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Alex-Bair
Copy link
Member

@Alex-Bair Alex-Bair commented Feb 25, 2025

Description:

A task has encountered a new 404 error when trying to fetch line items for a testmode Checkout Session. The error message is pretty specific, and the existing 404 handling logic can be extended to include this new error.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

Tested on a local stack. Confirmed that the capture does not crash when it receives this specific 404 error & it moves on to the next resource.


This change is Reviewable

@Alex-Bair Alex-Bair marked this pull request as ready for review February 25, 2025 15:43
@Alex-Bair Alex-Bair requested a review from a team February 25, 2025 15:43
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alex-Bair Alex-Bair merged commit d54473b into main Feb 25, 2025
83 of 88 checks passed
@Alex-Bair Alex-Bair deleted the bair/stripe-native-handle-404 branch February 25, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants