dekaf: Improve log filtering #1947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
force-pushed
the
dekaf/improved_log_filtering
branch
from
79e114a to
a481b56
Compare
Since we're now piping `tracing` logs into the task logs which is user facing, we'd like to make the logs we send as meaningful as possible. In order to do that, we need to be able to more narrowly specify which logs should get sent. In order to do that, I've swapped the simple log level filter for a slightly more advanced `tracing_subscriber::filter::Targets` which allows us to specify log filters such as `debug,simple_crypt=warn,aws_config=warn,h2=warn`.
jshearer
force-pushed
the
dekaf/improved_log_filtering
branch
from
a481b56 to
3d17463
Compare
|
Closing in favor of #1965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're now piping
tracinglogs into the task logs which is user facing, we'd like to make the logs we send as meaningful as possible. In order to do that, we need to be able to more narrowly specify which logs should get sent. In order to do that, I've swapped the simple log level filter for a slightly more advancedtracing_subscriber::filter::Targetswhich allows us to specify log filters such asdebug,simple_crypt=warn,aws_config=warn,h2=warn.An alternative to Arc<RwLock> would be something like the the
arc-swapcrate which provides a lock-free way to accomplish this shared mutable state, but since the usage pattern ofLOG_LEVELis pretty much entirely reads, I don't anticipate any actual lock contention to happen here and wanted to avoid yet another new dependency.This appears to have some locking issue, holding off for the moment.
This change is