dekaf: Add in easier-to-run tests #1957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in order to expose common functionality to be used by other crates Specifically, I want to be able to convert an input fixture spec into its corresponding built output, which is exactly what `validation_test::run()` does.
We weren't correctly narrowing the default of intersected shapes. For example, if we intersected one shape like
```json
{
"type": ["string", "null"],
"default": "null"
}
```
with another shape like
```json
{
"type": "string"
}
```
We'd end up with a shape of
```json
{
"type": "string",
"default": null
}
```
Which isn't correct, as when we try to actually emit a document for this shape that's missing the field
in question and provide its default value of null, that will subsequently fail to validate against the schema.
Fixes #1944
jshearer
deleted the
jshearer/dekaf_testing_and_fix_default_intersection
branch
jshearer
restored the
jshearer/dekaf_testing_and_fix_default_intersection
branch
|
Accidentally deleted this branch |
|
Closing in favor of #1965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
_meta/is_deletedvalidationtest infrastructure into sharedvalidation-testcrate in order to use it indekafSpecifically, I needed to be able to convert an input fixture spec into its corresponding built output, which is exactly whatvalidation_test::run()does.This change is