Increase sensitivity to backfill all button

estuary · Feb 20, 2025 · 13eb87d · 13eb87d
1 parent 846e14e
commit 13eb87d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/src/components/editor/Bindings/Backfill/BackfillButton.tsx b/src/components/editor/Bindings/Backfill/BackfillButton.tsx
@@ -151,16 +151,14 @@ function BackfillButton({
                     increment,
                     bindingMetadata
                 ).then(
-                    () => {
+                    (processedCollections) => {
                         const targetBindingUUID = singleBindingUpdate
                             ? currentBindingUUID
                             : undefined;
 
                         setBackfilledBindings(increment, targetBindingUUID);
 
-                        evaluateTrialCollections(
-                            bindingMetadata.map(({ collection }) => collection)
-                        ).then(
+                        evaluateTrialCollections(processedCollections).then(
                             (response) => {
                                 setCollectionMetadata(response, []);
                             },

diff --git a/src/components/editor/Bindings/Backfill/useUpdateBackfillCounter.ts b/src/components/editor/Bindings/Backfill/useUpdateBackfillCounter.ts
@@ -135,7 +135,15 @@ function useUpdateBackfillCounter() {
                 return Promise.reject(updateResponse.error);
             }
 
-            return mutateDraftSpecs();
+            const mutateResponse = await mutateDraftSpecs();
+
+            if (!mutateResponse) {
+                return Promise.reject();
+            }
+
+            return bindingMetadataExists
+                ? bindingMetadata.map(({ collection }) => collection)
+                : Object.keys(bindings);
         },
         [
             backfilledBindings,

diff --git a/src/stores/Binding/Store.ts b/src/stores/Binding/Store.ts
@@ -820,6 +820,7 @@ const getInitialState = (
                         sourceBackfillRecommended:
                             isBeforeTrialInterval(updated_at) &&
                             (added ||
+                                state.backfillAllBindings ||
                                 backfilledCollections.includes(catalog_name)),
                         trialStorage: true,
                         updatedAt: updated_at,