Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get resource config pointers using WASM #1414

Merged
merged 19 commits into from
Feb 12, 2025
Merged

Get resource config pointers using WASM #1414

merged 19 commits into from
Feb 12, 2025

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Jan 10, 2025 •
edited
Loading

Requires

Issues

#1382

Changes

1382

  • Made bindings save off pointers and then use computed values to get settings

Misc

  • Added a npm script to help fetch a local copy of flow-web

Tests

Manually tested

  • scenarios you manually tested

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

If applicable - please include some screenshots of the new UI

@travjenkins
Adding a script to help make developing flow web changes easier
b0cb903
@travjenkins
Adding a call to the new WASM endpoint to fetch pointers
2b4e833 
Storing those pointers in the store
Then updating checking support by using shared hook and useShallow
Broke up the binding store code a bit to help IDE slowness
@travjenkins
Basic typing to keep things more strict
c3c3e47 
Making calls to fetch default binding settings
Adding in support to pass through default binding settings
@travjenkins
Wrapping calls in a try catch to be a bit safer
7cf225a
@travjenkins
Changing variable name as WASM handles these now
ec6c34b 
Renaming functions to make a bit more sense
@travjenkins
Making sure all the fields are there. Probably need to work this into
a8d70a1 
 rust somehow
@travjenkins
Can just pass in the json and the wasm will handle the conversion
1d986f5
@travjenkins
Adding web flow for license
447b6a3 
Using a more proper term for the command
@travjenkins
Merge remote-tracking branch 'origin/main' into travjenkins/feature/a…
ddc7d15 
…dd-resource-config-wasm-support
@travjenkins
updating message
22b5b74
@travjenkins travjenkins marked this pull request as ready for review January 30, 2025 23:38
@travjenkins travjenkins requested a review from a team as a code owner January 30, 2025 23:38
@travjenkins travjenkins added the change:planned This is a planned change label Jan 31, 2025
@travjenkins travjenkins merged commit 1b1d6e0 into main Feb 12, 2025
3 checks passed
@travjenkins travjenkins deleted the travjenkins/feature/add-resource-config-wasm-support branch February 12, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiahna-tucker kiahna-tucker kiahna-tucker approved these changes

Assignees
No one assigned
Labels
change:planned This is a planned change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travjenkins @kiahna-tucker