prod: preserve included field constraints #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiahna-tucker
changed the title
travjenkins
approved these changes
Jan 30, 2025
kiahna-tucker
deleted the
kiahna-tucker/bug-repair/preserve-included-field-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
The issues directly below are completely resolved by this PR:
#1434
Changes
1434
The following features are included in this PR:
Create field selection-related interfaces to promote type consistency in field selection logic. The base
FieldSelectioninterface includes an optional,metaproperty which is used, presently, to store additional constraints for included fields.Rename
FieldSelectionDictionarytoBindingFieldSelectionsandFieldSelectiontoFieldSelectionDictionaryto clarify the information encapsulated by each interface.Tests
Manually tested
Approaches to testing are as follows:
Validate that included field constraints are preserved in the materialization create workflow when taking action on other fields in the field selection table.
Validate that included field constraints are preserved in the materialization edit workflow when taking action on other fields in the field selection table.
Automated tests
N/A
Playwright tests ran locally
Screenshots
N/A