Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update content on account access tab of admin page #1460

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Update content on account access tab of admin page #1460

merged 2 commits into from
Feb 11, 2025

Conversation

kiahna-tucker
Copy link
Member

@kiahna-tucker kiahna-tucker commented Feb 10, 2025 •
edited
Loading

Issues

The issues directly below are advanced by this PR:
#1457

Changes

1457

  • Update the content on the Account Access tab of the Admin page as specified in the linked issue. Changes dependent on the new classification of user will be made at a later date.

Tests

Manually tested

  • Validate that the new content appears in the application.

Automated tests

N/A

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

Data sharing table toolbar

pr_screenshot-0000-account_access_content-data_sharing_table_toolbar

Data sharing change dialog | Access removal in progress

pr_screenshot-0000-account_access_content-tenant_sharing_removing

Data sharing change dialog | Access removal completed

pr_screenshot-0000-account_access_content-tenant_sharing_removed

Organization membership table toolbar

pr_screenshot-0000-account_access_content-organization_membership_table_toolbar

Add user dialog | Active invite links table empty

pr_screenshot-0000-account_access_content-add_users_dialog-table_empty

Add user dialog | Active invite links table populated

pr_screenshot-0000-account_access_content-add_users_dialog

Organization membership change dialog | Access removal in progress

pr_screenshot-0000-account_access_content-user_removing

Organization membership change dialog | Access removal completed

pr_screenshot-0000-account_access_content-user_removed

@kiahna-tucker kiahna-tucker added the change:planned This is a planned change label Feb 10, 2025
@kiahna-tucker kiahna-tucker marked this pull request as ready for review February 10, 2025 20:47
@kiahna-tucker kiahna-tucker requested a review from a team as a code owner February 10, 2025 20:47
travjenkins
travjenkins approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - in the future you shouldn't update the key for something like this

@travjenkins
Copy link
Member

I did not test... cause it is mainly content changes

@kiahna-tucker kiahna-tucker merged commit e624224 into main Feb 11, 2025
3 checks passed
@kiahna-tucker kiahna-tucker deleted the kiahna-tucker/content/organization-membership branch February 11, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travjenkins travjenkins travjenkins approved these changes

Assignees
No one assigned
Labels
change:planned This is a planned change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiahna-tucker @travjenkins