Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storage mapping provider label for Amazon S3 #1463

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

kiahna-tucker
Copy link
Member

@kiahna-tucker kiahna-tucker commented Feb 12, 2025

Issues

The issues directly below are completely resolved by this PR:
#1462

Changes

1462

The following features are included in this PR:

  • Change the label for the S3 storage mapping provider option to Amazon S3.

Tests

Manually tested

Approaches to testing are as follows:

  • Validate the S3 storage mapping provider option label is Amazon S3.

Automated tests

Logic updated for the following Playwright tests:

  • admin.spec.ts

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

Storage mapping provider selector | Menu options

pr_screenshot-1463-s3_option_label-deselected

Storage mapping provider selector | Amazon S3 option selected

pr_screenshot-1463-s3_option_label-selected

@kiahna-tucker kiahna-tucker added the change:planned This is a planned change label Feb 12, 2025
@kiahna-tucker kiahna-tucker marked this pull request as ready for review February 12, 2025 14:30
@kiahna-tucker kiahna-tucker requested a review from a team as a code owner February 12, 2025 14:30
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kiahna-tucker kiahna-tucker merged commit 4ab35c3 into main Feb 12, 2025
3 checks passed
@kiahna-tucker kiahna-tucker deleted the kiahna-tucker/content/aws-s3-storage-mapping branch February 12, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:planned This is a planned change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants