Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Connector and Data Plane auto complete rendering properly with arrows #1466

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

travjenkins
Copy link
Member

Issues

#1407

Changes

1407

  • Switch out the custom stuff to a more standard approach that uses MUI Input component that allows for easy used of end/start and drop down icon
  • Had to disable clear as that was now added by nature of using the standard approach.

Tests

Manually tested

  • scenarios you manually tested

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

image

Just using the standard `Input` mui components to keep things simple
Adding disableClear because clearing would now work
@travjenkins travjenkins changed the title Travjenkins/feature/add arrow to dp selector Get Connector and Data Plane auto complete rendering properly with arrows Feb 13, 2025
@travjenkins travjenkins marked this pull request as ready for review February 13, 2025 22:21
@travjenkins travjenkins requested a review from a team as a code owner February 13, 2025 22:21
@kiahna-tucker kiahna-tucker added the change:planned This is a planned change label Feb 18, 2025
@travjenkins travjenkins merged commit bf28a55 into main Feb 20, 2025
3 checks passed
@travjenkins travjenkins deleted the travjenkins/feature/add-arrow-to-dp-selector branch February 20, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:planned This is a planned change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants