Show users data plane details and split up cidr blocks #1474
Conversation
Keeping which option they chose in local storage
Using component to render CIDR Blocks
| {hasSupportRole ? ( | ||
| <Stack> | ||
| <Divider sx={{ mt: 2, mb: 4 }} /> | ||
| <Stack> |
There was a problem hiding this comment.
We'll just always show to users now
There was a problem hiding this comment.
Previously rendering cidr blocks was simple. This isn't too complex but best to keep it in a single place since we render these in the table and the config forms.
Some stuff is hardcoded - but I think it is fine since IPs do not change too often
| const [defaultDataPlane, setDefaultDataPlane] = | ||
| useLocalStorage<DataPlaneScopes>( | ||
| LocalStorageKeys.ADMIN_DATAPLANE_CHOICE, | ||
| defaultOption | ||
| ); |
There was a problem hiding this comment.
Trying to make the UX better and not make users have to constantly switch between public and private. Eventually - this should be a setting stored with the select tenant.
| @@ -13,7 +13,8 @@ export const JsonForms: Record<string, string> = { | |||
| 'dateTimePicker.picker.footer': `Timezone: UTC`, | |||
| 'datePicker.button.ariaLabel': `Open date picker for {label}`, | |||
| 'informational.sshEndpoint.title': `All Estuary traffic comes from a group of IPs that can be whitelisted:`, | |||
| 'informational.sshEndpoint.ip': `34.121.207.128, 35.226.75.135, 34.68.62.148`, | |||
| 'informational.sshEndpoint.ipv4': `34.121.207.128, 35.226.75.135, 34.68.62.148`, | |||
| 'informational.sshEndpoint.ipv6': `does not support IPv6`, | |||
There was a problem hiding this comment.
Very rare this would ever hit for something not related to the public data plan - but still kept the message open ended.
| @@ -13,7 +13,8 @@ export const JsonForms: Record<string, string> = { | |||
| 'dateTimePicker.picker.footer': `Timezone: UTC`, | |||
| 'datePicker.button.ariaLabel': `Open date picker for {label}`, | |||
| 'informational.sshEndpoint.title': `All Estuary traffic comes from a group of IPs that can be whitelisted:`, | |||
| 'informational.sshEndpoint.ip': `34.121.207.128, 35.226.75.135, 34.68.62.148`, | |||
| 'informational.sshEndpoint.ipv4': `34.121.207.128, 35.226.75.135, 34.68.62.148`, | |||
There was a problem hiding this comment.
Only the key changed
travjenkins
changed the title
Issues
#1470
Changes
1470
Data Planessection in adminTests
Manually tested
Automated tests
Playwright tests ran locally
Screenshots
Admin table public ipv4
Admin table public ipv6
Config shows ipv4
config showing ipv6