Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example apps to use dart_eval 0.7.9, support Flutter 3.22 #83

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

wrbl606
Copy link
Contributor

@wrbl606 wrbl606 commented Jun 7, 2024

In Flutter 3.22.0 deprecated Material text styles (.headline1/2/3/..., body1/2/..., etc.) got removed, breaking the bridge implementation.
Also, Flutter bindings should be regenerated for Flutter 3.22.+

@ethanblake4
Copy link
Owner

Thank you! Just one Q - why did you replace EvalWidget with CompilerWidget in the example?

@wrbl606
Copy link
Contributor Author

wrbl606 commented Jun 9, 2024

The example wasn't working because of the lacking program.evc asset. I figured, to make the example easier to get up and running, it be best to replace it with CompilerWidget so newbies will be able to alter the demo code and see the effects without any hoops.

@wrbl606
Copy link
Contributor Author

wrbl606 commented Jun 15, 2024

@ethanblake4 should I revert this back to EvalWidget then? Devs on Flutter stable 3.22+ might have issue running this.

@ethanblake4
Copy link
Owner

EvalWidget should behave the same way as CompilerWidget in debug mode, so I'm not sure why there would be a missing asset error unless you are trying to run it in release mode? If it does have one in debug mode there is a bug.

@wrbl606
Copy link
Contributor Author

wrbl606 commented Jun 21, 2024

I don't think that running the demo app in release mode is uncommon, I'd definitely would do that if I'd to evaluate the solution.

@wrbl606
Copy link
Contributor Author

wrbl606 commented Jun 28, 2024

As stated, I think the CompilerWidget is more beginner friendly. If users hit any performance issue with the compilation in runtime, they can the switch to the more advanced optimisation technique using the EvalWidget. @ethanblake4 what do you think?

@wrbl606
Copy link
Contributor Author

wrbl606 commented Jun 30, 2024

@ethanblake4 You seem busy with other things, would you trust me enough to give me push access to main and an option to publish new version of the package? It has been 3 weeks since the incompatibility of flutter_eval with the newest stable Flutter version was fixed, while currently published flutter_eval version prevents the package users from upgrading to Flutter 3.22+, or, worst yet, new users are unable to try the project out while I publish new content about it.

I really don't want to see this project fall into obscurity.

@ethanblake4
Copy link
Owner

Hi, I'm currently on vacation in Japan so indeed will be a bit slow to get around to things. Please be patient, I should have time in the next few days. Thank you.

@wrbl606
Copy link
Contributor Author

wrbl606 commented Jul 1, 2024

Have a great time!

@wrbl606 wrbl606 mentioned this pull request Jul 1, 2024
@ethanblake4 ethanblake4 merged commit 98f47b4 into ethanblake4:master Jul 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants