Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cork Mainnet Updates #72

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Cork Mainnet Updates #72

wants to merge 9 commits into from

Conversation

heri16
Copy link
Contributor

@heri16 heri16 commented Feb 13, 2025 •
edited
Loading

  • updated Cork deployment addresses on Ethereum mainnet
  • updated with final ABIs (after Cork's smart contract audits)
  • updated code to align with the Uniswap v4 design, where the Pool Manager holds Ethena Token balances
  • Updated code to align with the Uniswap v4 design, where the LPT Token contract is lazily created during poolManager.initialize() upon the first liquidity addition to the AMM.
  • Fixed contract.getABI() deprecation warning since web3 v6.19. Switched to contract.get_abi()
  • Fixed ERC20 burn detection
  • Exclude unknown Uniswap v4 pools (that are not managed by Cork)
  • Add workaround for missing PsmDeposited events using valueLocked()
  • Add assertion in case of mismatched balances or bad contract upgrade in future

heri16
heri16 commented Feb 19, 2025
View reviewed changes
Copy link
Contributor Author

@heri16 heri16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heri16
Copy link
Contributor Author

heri16 commented Mar 4, 2025 •
edited
Loading

Verified Balances are matching. See Spreadsheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@heri16