Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amax chain #6715

Merged
merged 11 commits into from
Feb 7, 2025
Merged

Update amax chain #6715

merged 11 commits into from
Feb 7, 2025

Conversation

ultronchain
Copy link
Contributor

No description provided.

ultronchain and others added 9 commits April 19, 2024 15:37
Rename chain details from UltronSmartchain to AmaxSmartchain, including:
- Chain name
- RPC endpoint
- Native currency name and symbol
- Info URL
- Short name
- Icon name
- Explorer details
Copy link

github-actions bot commented Feb 2, 2025

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add redFlags reusedChainId

@ultronchain
Copy link
Contributor Author

Hi @ligi,

I've added the reusedChainId flag to the eip155-662.json file as requested. Could you kindly review the changes and let me know if anything else is needed?

Thanks for your time and guidance!

@ultronchain ultronchain requested a review from ligi February 6, 2025 11:12
@ligi ligi merged commit 13c87fb into ethereum-lists:master Feb 7, 2025
5 checks passed
Copy link

github-actions bot commented Feb 7, 2025

PR merged - please consider contributing some funds to lists.eth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants