Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monorepo dependency to Holocene release commit #136

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

mininny
Copy link
Collaborator

@mininny mininny commented Jan 23, 2025

Description

Update Optimism monorepo's dependency to holocene release commit ethereum-optimism/optimism@8bf7ff6.

Includes the following changes:

  • Update git submodule of optimism and forge-std
  • Update code changes from the monorepo dependency
  • Update Deploy scripts, especially for changed solidity file location in imports
  • Update CircleCI pipeline, mostly mirrored from monorepo updates
    • Remove geth-version-checker.sh
  • Update geth abigen dependency and generated bindings
  • Update op-program-test data and test data generation script

One specific change to note is: cb5e8b2

  • Currently, Asterisc is aimed to only support Kona. However, the testing infrastructure (such as op-e2e tests) rely on running Asterisc with op-program.
  • In the latest op-program version, the op-program introduces the usage of syscall SysNanosleep.
  • However, this syscall is known to be not used in Kona and thus is safe to be not implemented.
  • As we need to run op-program with Asterisc for now, this PR will no-op the syscall SysNanosleep. In a future work, we'll remove testing with op-program from Asterisc, which will effectively allow us to remove this exception.

One change in CI pipeline: edb234c

  • Run mise install in monorepo as well
  • Change ci-builder image to cimg/base for more lightweight ci

Tests

All existing circleci tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.42%. Comparing base (7654638) to head (84dda89).
Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   62.45%   62.42%   -0.04%     
==========================================
  Files          27       27              
  Lines        4158     4154       -4     
==========================================
- Hits         2597     2593       -4     
  Misses       1423     1423              
  Partials      138      138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mininny mininny force-pushed the feature/mininny/monorepo-holocene branch from f555beb to ee1664b Compare February 1, 2025 09:53
@mininny mininny changed the title Monorepo update to support holocene Update monorepo dependency to Holocene release commit Feb 2, 2025
@mininny mininny force-pushed the feature/mininny/monorepo-holocene branch 4 times, most recently from 4887ee5 to 2832dcf Compare February 3, 2025 00:30
@mininny mininny force-pushed the feature/mininny/monorepo-holocene branch from 2832dcf to edb234c Compare February 3, 2025 00:34
@mininny mininny marked this pull request as ready for review February 3, 2025 00:59
@mininny mininny requested review from ImTei, janjakubnanista and clabby and removed request for ImTei and janjakubnanista February 3, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants