Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate tag-service workflow to CircleCI #126

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

janjakubnanista
Copy link
Contributor

@janjakubnanista janjakubnanista commented Jan 17, 2025

Description

Migrating tag-service manual github actions workflow to CircleCI. The setup is made a bit more complex since this project is using CircleCI's dynamic setup.

  • Added an extra set of pipeline parameters that control the new tag-service job. These will be empty if the pipeline is run because of a push, they need to be specified when manually triggering a pipeline from CircleCI's UI.
    • To make the UX a bit more sturdy and nicer, these parameters are defined both in config.yml (strict definition, this definition populates the UI form for triggering pipelines) and continue_config.yml (so that they can be used in the actual job)
  • Replaced inlined executors with executors definitions. This way the vm-image pipeline parameter that was used to DRY the config can be dropped

I also added mise as a dependency manager. mise is being used in the optimism monorepo and provides a great way of managing tooling required for development.

It is an add-on, it does not break or affect any existing development flows, just provides a convenient way of setting up your development environment (as well as the CI environment).

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

@janjakubnanista janjakubnanista requested a review from a team as a code owner January 17, 2025 21:43
@janjakubnanista janjakubnanista requested a review from tynes January 17, 2025 21:43
@janjakubnanista janjakubnanista self-assigned this Jan 17, 2025
@janjakubnanista janjakubnanista changed the title Jan/circleci 001 chore: Migrate tag-service workflow to CircleCI Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant