-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Smart Blobs #380
base: master
Are you sure you want to change the base?
Add ERC: Smart Blobs #380
Conversation
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This proposal reads more like documentation for a specific project than a specification for a protocol. For example, curl
commands aren't exactly common in EIPs.
You need to rewrite this as a document describing the expected behaviour of the system and the integration points with other systems/users.
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
The commit 25c2b27 (as a parent of cf7ecc0) contains errors. |
@SamWilsn we've made revisions based on your feedback. Would be great if you could re-review. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid there still isn't enough depth here for an EIP. I could entirely be wrong. I'm not an expert on Arweave, or even on L2s.
Could I, after reading just this document, implement a compatible sequencer?
What does "indexes the state changes in the cloud" mean? Is the encoding of blob data when sent to Arweave well specified?
Like... I just get the vibe that there's a ton more here that needs to be written before someone could actually implement this proposal.
#### Contract deployment | ||
```json | ||
{ | ||
"type": 1, | ||
"sc": [], | ||
"state":[] | ||
} | ||
``` | ||
#### Contract call | ||
```json | ||
{ | ||
"type": 2, | ||
"inputs": [], | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required for merging, but personally I'd like to see JSON Schema whenever an EIP describes a JSON blob.
|
||
- `l1_gas_fees`: The gas paid to post the transaction to the EVM network. | ||
- `262604`: The total byte size of an `EIP-4844` transaction when archiving on Arweave. This includes data, KZG commitments, and proof. | ||
- `winston_byte_price`: The cost price per byte on Arweave. This is dynamic and can be checked at `https://arweave.net/price/262604`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `winston_byte_price`: The cost price per byte on Arweave. This is dynamic and can be checked at `https://arweave.net/price/262604`. | |
- `winston_byte_price`: The cost price per byte on Arweave. This is dynamic. |
We do not permit external links.
Agreed, this probably should be abstracted from arweave per se, but maybe just generalized "permanent storage network with probabilistic DA guarantee". |
Just checking in to see if you're still interested in pursuing this proposal. |
https://ethereum-magicians.org/t/erc-7689-smart-blobs/19672