Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Smart Blobs #380

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add ERC: Smart Blobs #380

wants to merge 16 commits into from

Conversation

charmful0x
Copy link

@charmful0x charmful0x commented Apr 15, 2024

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Apr 15, 2024

File ERCS/erc-7689.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

@charmful0x charmful0x requested a review from wjmelements April 15, 2024 21:20
@github-actions github-actions bot added w-ci and removed w-ci labels Apr 16, 2024
charmful0x and others added 2 commits April 16, 2024 11:55
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@github-actions github-actions bot removed the w-ci label Apr 16, 2024
@github-actions github-actions bot removed the w-ci label Apr 17, 2024
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposal reads more like documentation for a specific project than a specification for a protocol. For example, curl commands aren't exactly common in EIPs.

You need to rewrite this as a document describing the expected behaviour of the system and the integration points with other systems/users.

charmful0x and others added 4 commits June 14, 2024 10:31
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Copy link

The commit 25c2b27 (as a parent of cf7ecc0) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Jun 14, 2024
@github-actions github-actions bot removed the w-ci label Jun 14, 2024
@charmful0x charmful0x requested a review from SamWilsn June 14, 2024 15:41
@xylophonez
Copy link

@SamWilsn we've made revisions based on your feedback. Would be great if you could re-review. Cheers!

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid there still isn't enough depth here for an EIP. I could entirely be wrong. I'm not an expert on Arweave, or even on L2s.

Could I, after reading just this document, implement a compatible sequencer?

What does "indexes the state changes in the cloud" mean? Is the encoding of blob data when sent to Arweave well specified?

Like... I just get the vibe that there's a ton more here that needs to be written before someone could actually implement this proposal.

Comment on lines +44 to +58
#### Contract deployment
```json
{
"type": 1,
"sc": [],
"state":[]
}
```
#### Contract call
```json
{
"type": 2,
"inputs": [],
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required for merging, but personally I'd like to see JSON Schema whenever an EIP describes a JSON blob.


- `l1_gas_fees`: The gas paid to post the transaction to the EVM network.
- `262604`: The total byte size of an `EIP-4844` transaction when archiving on Arweave. This includes data, KZG commitments, and proof.
- `winston_byte_price`: The cost price per byte on Arweave. This is dynamic and can be checked at `https://arweave.net/price/262604`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `winston_byte_price`: The cost price per byte on Arweave. This is dynamic and can be checked at `https://arweave.net/price/262604`.
- `winston_byte_price`: The cost price per byte on Arweave. This is dynamic.

We do not permit external links.

@angrymouse
Copy link

Agreed, this probably should be abstracted from arweave per se, but maybe just generalized "permanent storage network with probabilistic DA guarantee". winston_byte_price probably should be storage_network_byte_price or so.
I think arweave belongs much more to "implementation detail". In fact, the more mediums you store/fetch historical data from - the more secure overall Smart Blobs scheme becomes.

@SamWilsn
Copy link
Contributor

Just checking in to see if you're still interested in pursuing this proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants