Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Union Lock #382

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Add ERC: Union Lock #382

wants to merge 17 commits into from

Conversation

1999321
Copy link

@1999321 1999321 commented Apr 16, 2024

The feature of Union Lock can query the number of calls of other contracts and the number of calls of other contract functions in the same Ethereum transaction, thereby realizing the cross-contract locking function.

Union Lock is based on EIP-1153 , it can make DApps avoid flash loan attacks.

Discuss: https://ethereum-magicians.org/t/union-lock-based-on-tstore-tload-can-avoid-flash-loan-attacks/19676

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Apr 16, 2024

File ERCS/erc-7690.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

@1999321
Copy link
Author

1999321 commented Apr 16, 2024

Links to EIP1153 cannot be introduced.

@github-actions github-actions bot removed the w-ci label Apr 23, 2024
@github-actions github-actions bot added the w-ci label Apr 23, 2024
Copy link

The commit 2e44ee3 (as a parent of a41e7d4) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci label Jun 18, 2024
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After resolving these comments, I think this'll be good to merge as a draft. You'll want to work a bit on your readability/grammar before moving to review.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove build system related files from the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove build system files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove build system files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove build system files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this file is. Is it included intentionally?

Copy link

There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants