-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-2333: Move to Last Call #386
base: master
Are you sure you want to change the base?
Conversation
Taking this straight to |
@@ -1,32 +1,25 @@ | |||
--- | |||
eip: 2334 | |||
title: BLS12-381 Deterministic Account Hierarchy | |||
description: BLS12-381 Deterministic account hierarchy structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your description doesn't really add a lot of information that isn't already in the title. Maybe:
description: BLS12-381 Deterministic account hierarchy structure | |
description: Define the purpose of a key (or family of keys) within a tree of keys. |
discussions-to: https://github.com/ethereum/EIPs/issues/2338 | ||
status: Stagnant | ||
discussions-to: https://ethereum-magicians.org/t/bls-keys-related-erc-discussion-erc-2333-2334-2335/19774 | ||
status: Final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: Final | |
status: Last Call | |
last-call-deadline: 2024-06-11 |
You'll need to go through a last call period.
discussions-to: https://github.com/ethereum/EIPs/issues/2339 | ||
status: Stagnant | ||
discussions-to: https://ethereum-magicians.org/t/bls-keys-related-erc-discussion-erc-2333-2334-2335/19774 | ||
status: Final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: Final | |
status: Last Call | |
last-call-deadline: 2024-06-11 |
@@ -1,36 +1,29 @@ | |||
--- | |||
eip: 2335 | |||
title: BLS12-381 Keystore | |||
description: Keystore for storing BLS12-381 keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Keystore for storing BLS12-381 keys | |
description: JSON format for the storage and interchange of BLS12-381 private keys. |
Your simple summary was great. Might as well re-use it!
The commit 31e6d29 (as a parent of dc6a671) contains errors. |
There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
Bring ERC 2333, 2334, 2335 up to date.
These ERCs are already the standard for BLS keys as used within the Beacon chain. This PR brings the ERCs up to date and sets them to
Last Call
so they can becomeFinal
ASAP to line up with their actual status.