Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC-XXXX #523

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add ERC-XXXX #523

wants to merge 7 commits into from

Conversation

1999321
Copy link

@1999321 1999321 commented Jul 8, 2024

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@1999321 1999321 requested a review from eip-review-bot as a code owner July 8, 2024 10:38
@1999321 1999321 changed the title Erc brach Add ERC-XXXX Jul 8, 2024
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jul 8, 2024

🛑 eip-review-bot failed for an unknown reason. Please see logs for more details, and report this issue at the eip-review-bot repository.

Copy link

gitguardian bot commented Jul 8, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Alchemy API Key 154e08a assets/erc-xxxx/lib/forge-std/src/StdChains.sol View secret
- Alchemy API Key 154e08a assets/erc-xxxx/lib/forge-std/foundry.toml View secret
- Alchemy API Key 154e08a assets/erc-xxxx/lib/forge-std/test/StdChains.t.sol View secret
- Alchemy API Key 154e08a assets/erc-xxxx/lib/forge-std/test/StdChains.t.sol View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

If this detection is a false positive, please contact Oleh Vasylenko (@Aldekein) to fix it in the GitGuardian dashboard.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

github-actions bot commented Jul 8, 2024

The commit 6226647 (as a parent of bb2bb4f) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Jul 8, 2024
@@ -0,0 +1,198 @@
---
eip: -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: -
eip: 7737

Assigning next sequential EIP/ERC/RIP number.

Please also update the filename.

title: Custom data access model
description: Custom data access model is a design model that supports any form of access to the contract's storage to obtain the corresponding data.
author: Elon Lee (@1999321)
discussions-to: https://ethereum-magicians.org/t/custom-data-access-model/20337
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
discussions-to: https://ethereum-magicians.org/t/custom-data-access-model/20337
discussions-to: https://ethereum-magicians.org/t/erc-7737-custom-data-access-model/20337

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all of forge from your pull request.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add submodules.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to your EIP

Copy link

github-actions bot commented Mar 1, 2025

There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants