-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC-XXXX #523
base: master
Are you sure you want to change the base?
Add ERC-XXXX #523
Conversation
🛑 |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | Alchemy API Key | 154e08a | assets/erc-xxxx/lib/forge-std/src/StdChains.sol | View secret | |
- | Alchemy API Key | 154e08a | assets/erc-xxxx/lib/forge-std/foundry.toml | View secret | |
- | Alchemy API Key | 154e08a | assets/erc-xxxx/lib/forge-std/test/StdChains.t.sol | View secret | |
- | Alchemy API Key | 154e08a | assets/erc-xxxx/lib/forge-std/test/StdChains.t.sol | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
If this detection is a false positive, please contact Oleh Vasylenko (@Aldekein) to fix it in the GitGuardian dashboard.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
The commit 6226647 (as a parent of bb2bb4f) contains errors. |
@@ -0,0 +1,198 @@ | |||
--- | |||
eip: - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eip: - | |
eip: 7737 |
Assigning next sequential EIP/ERC/RIP number.
Please also update the filename.
title: Custom data access model | ||
description: Custom data access model is a design model that supports any form of access to the contract's storage to obtain the corresponding data. | ||
author: Elon Lee (@1999321) | ||
discussions-to: https://ethereum-magicians.org/t/custom-data-access-model/20337 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussions-to: https://ethereum-magicians.org/t/custom-data-access-model/20337 | |
discussions-to: https://ethereum-magicians.org/t/erc-7737-custom-data-access-model/20337 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all of forge from your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add submodules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not related to your EIP
There has been no activity on this issue for six months. It will be closed in 7 days if there is no new activity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: