Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: App Keys for Fully Embedded Accounts #615

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

danfinlay
Copy link

As we build infrastructure that facilitates embedded wallets, sites have a new opportunity to manage keys to manage permissions they receive (like via ERC-7715).

Alternatively, the site may want to defer key backup to the wallet, while still wanting the benefits of being able to sign on their own behalves.

This is one extremely minimal initial approach to granting sites key material that is deterministically generated to them. It probably needs some refinement in its algorithm, but can be treated as a general outline of an approach for consideration even in this initial draft form.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Sep 4, 2024

File ERCS/erc-7763.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

@github-actions github-actions bot added the w-ci label Sep 4, 2024
@eip-review-bot eip-review-bot changed the title Add ERC: wallet_getExposedAppKey Add ERC: Smart Contract Delegation Interfaces Sep 4, 2024
@danfinlay danfinlay changed the title Add ERC: Smart Contract Delegation Interfaces Add ERC: wallet_getExposedAppKey Sep 4, 2024
@danfinlay danfinlay force-pushed the wallet_getExposedAppKey branch from bca569a to f793cf0 Compare September 4, 2024 20:45
@danfinlay
Copy link
Author

Sorry, had some files from other branches. Cleaning up.

@eip-review-bot eip-review-bot changed the title Add ERC: wallet_getExposedAppKey Website: wallet_getExposedAppKey Sep 4, 2024
@danfinlay danfinlay force-pushed the wallet_getExposedAppKey branch from f793cf0 to e972ff0 Compare September 4, 2024 20:46
@eip-review-bot eip-review-bot changed the title Website: wallet_getExposedAppKey Add ERC: Exposed App Keys for Application-Specific Wallet Accounts Sep 4, 2024
@eip-review-bot eip-review-bot changed the title Add ERC: Exposed App Keys for Application-Specific Wallet Accounts Update ERC-7677: Move to Review Sep 4, 2024
@danfinlay danfinlay force-pushed the wallet_getExposedAppKey branch from 158a896 to 3fdb552 Compare September 4, 2024 20:50
As we build infrastructure that facilitates embedded wallets, sites have a new opportunity to manage keys to manage permissions they receive (like via ERC-7715).

Alternatively, the site may want to defer key backup to the wallet, while still wanting the benefits of being able to sign on their own behalves.

This is one extremely minimal initial approach to granting sites key material that is deterministically generated to them. It probably needs some refinement in its algorithm, but can be treated as a general outline of an approach for consideration even in this initial draft form.
@github-actions github-actions bot removed the w-ci label Sep 4, 2024
@danfinlay danfinlay force-pushed the wallet_getExposedAppKey branch from 3fdb552 to 1d2de27 Compare September 4, 2024 20:51
@eip-review-bot eip-review-bot changed the title Update ERC-7677: Move to Review Add ERC: Exposed App Keys for Application-Specific Wallet Accounts Sep 4, 2024
@github-actions github-actions bot added the w-ci label Sep 4, 2024
danfinlay and others added 2 commits September 4, 2024 20:35
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@github-actions github-actions bot removed the w-ci label Sep 5, 2024
@danfinlay danfinlay force-pushed the wallet_getExposedAppKey branch from cdcdfb6 to 3bb1270 Compare September 5, 2024 03:42
@github-actions github-actions bot added the w-ci label Sep 5, 2024
@danfinlay danfinlay changed the title Add ERC: Exposed App Keys for Application-Specific Wallet Accounts ERC-7763: App Keys for Fully Embedded Accounts Sep 5, 2024
@github-actions github-actions bot removed the w-ci label Sep 5, 2024
@eip-review-bot eip-review-bot changed the title ERC-7763: App Keys for Fully Embedded Accounts Add ERC: App Keys for Fully Embedded Accounts Sep 5, 2024
@github-actions github-actions bot added the w-ci label Sep 5, 2024
danfinlay and others added 2 commits September 6, 2024 07:30
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self, this is blocked on #436.

As the Ethereum ecosystem continues to evolve, standardized approaches to key management and permissions become increasingly important. This ERC aims to contribute to the ongoing development of user-friendly and secure wallet interfaces, fostering innovation in decentralized applications while maintaining strong security practices.

By adopting this standard, wallets and dApps can work together more effectively, providing users with a more streamlined and secure experience in the Web3 environment. As the community continues to refine and expand upon these concepts, we anticipate further improvements in user experience, security, and interoperability across the Ethereum ecosystem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Copyright
Copyright and related rights waived via [CC0](../LICENSE.md).

The copyright section is not optional.

Comment on lines +123 to +131
## Conclusion

This ERC proposes a standardized method for wallets to generate and manage app-specific keys, providing a secure and consistent approach to permission management in decentralized applications. By implementing this standard, wallets can offer enhanced privacy and security for users while enabling more seamless interactions between dApps and user accounts.

The proposed `wallet_getAppKey` method allows for the creation of unique, deterministic keys for each application, reducing the risk of cross-app tracking and improving overall user privacy. This approach also facilitates easier permission management and potential future upgrades to more advanced account structures.

As the Ethereum ecosystem continues to evolve, standardized approaches to key management and permissions become increasingly important. This ERC aims to contribute to the ongoing development of user-friendly and secure wallet interfaces, fostering innovation in decentralized applications while maintaining strong security practices.

By adopting this standard, wallets and dApps can work together more effectively, providing users with a more streamlined and secure experience in the Web3 environment. As the community continues to refine and expand upon these concepts, we anticipate further improvements in user experience, security, and interoperability across the Ethereum ecosystem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this content probably belongs in the Motivation section, since it's trying to convince the reader to pick this particular standard.

Copy link

The commit 85cd73a (as a parent of 4229bc8) contains errors.
Please inspect the Run Summary for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants