Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new lint for space in Headers #87

Merged
merged 8 commits into from
Jan 21, 2024
Merged

Add new lint for space in Headers #87

merged 8 commits into from
Jan 21, 2024

Conversation

0xRampey
Copy link
Contributor

@0xRampey 0xRampey commented Sep 19, 2023 •
edited
Loading

Addresses Issue #40

Also have to add docs for the new lint. Is there a cargo command to generate the required html file?

SamWilsn
SamWilsn requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks so much for the contribution! I completely missed this pull request.

Just these two test cases, and I think it'll be good to go.

eipw-lint/tests/lint_markdown_headings_space.rs Show resolved Hide resolved
@SamWilsn
Copy link
Contributor

Is there a cargo command to generate the required html file?

Nope, they're just done by hand

@0xRampey
Match nodes at start of line
51ab612 
- Add docs and test
@0xRampey 0xRampey requested a review from SamWilsn January 21, 2024 18:24
@SamWilsn SamWilsn merged commit 93266e6 into ethereum:master Jan 21, 2024
5 checks passed
@0xRampey 0xRampey deleted the lint/headings-space branch January 21, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn Awaiting requested review from SamWilsn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xRampey @SamWilsn