SMTChecker: Fix reporting same target both as safe and unsafe #15853
+54
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This actually affects several of SMTChecker tests. I've checked a few of them and it was indeed the same situation as in the linked issue. |
blishko
force-pushed
the
smt-fix-target-report
branch
from
c8dfa93 to
4b2df57
Compare
The same verification target can be analyzed in the context of different contracts. If the target is safe in the context of one contract, but can be violated in the context of another contract, model checker may report it both safe and unsafe (depending on the order of the analyzed contract). Note that if one violation of a target has been detected, the same target if ignored later. However, if it was first shown safe, that information would be kept and displayed to the user. The proposed fix checks if an unsafe target has previously been shown safe, and if so, this information is deleted.
blishko
force-pushed
the
smt-fix-target-report
branch
from
4b2df57 to
b0485e4
Compare
ekpyron
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same verification target can be analyzed in the context of different contracts.
If the target is safe in the context of one contract, but can be violated in the context of another contract, model checker may report it both safe and unsafe (depending on the order of the analyzed contracts).
Note that if one violation of a target has been detected, the same target is ignored later.
However, if it was first shown safe, that information would be kept and displayed to the user.
The proposed fix checks if an unsafe target has previously been shown safe, and if so, this information is deleted.
Resolves #15849.