Skip to content

Commit

Permalink
HA-415 - Adding new data_types: time, date and datetime
Browse files Browse the repository at this point in the history
  • Loading branch information
andres-torres-marroquin committed Jan 30, 2025
1 parent 648ebb1 commit 3c84d10
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/fideslang/validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@ def parse_data_type_string(type_string: Optional[str]) -> Tuple[Optional[str], b
"boolean",
"object_id",
"object",
"time",
"date",
"datetime",
}


Expand Down
33 changes: 33 additions & 0 deletions tests/fideslang/test_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,39 @@ def test_valid_length(self):


class TestValidateDatasetField:

@pytest.mark.parametrize("data_type", ["string", "integer", "float", "boolean", "object", "time", "date", "datetime"])
def test_valid_types(self, data_type):
field = DatasetField(
name="test_field",
fides_meta=FidesMeta(
references=None,
identity="identifiable_field_name",
primary_key=False,
data_type=data_type,
length=None,
return_all_elements=None,
read_only=None,
),
)
assert field.fides_meta.data_type == data_type

@pytest.mark.parametrize("data_type", ["not_string", "not_integer", "not_float", "not_boolean", "not_object", "not_time", "not_date", "not_datetime"])
def test_invalid_types(self, data_type):
field = DatasetField(
name="test_field",
fides_meta=FidesMeta(
references=None,
identity="identifiable_field_name",
primary_key=False,
data_type="string",
length=None,
return_all_elements=None,
read_only=None,
),
)
assert field.fides_meta.data_type == "string"

def test_return_all_elements_not_array_field(self):
with pytest.raises(ValidationError) as exc:
DatasetField(
Expand Down

0 comments on commit 3c84d10

Please sign in to comment.