Skip to content

Commit

Permalink
Merge pull request #10 from ethyca/asachs/support-gvl-deleted-date
Browse files Browse the repository at this point in the history
add a `System.vendor_deleted_date` property
  • Loading branch information
adamsachs authored May 6, 2024
2 parents c53726c + 69e3a47 commit ae88104
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ The types of changes are:
- `Fixed` for any bug fixes.
- `Security` in case of vulnerabilities.

## [Unreleased](https://github.com/ethyca/fideslang/compare/3.0.0...main)
## [Unreleased](https://github.com/ethyca/fideslang/compare/3.0.1...main)

## [3.0.1](https://github.com/ethyca/fideslang/compare/3.0.0...3.0.1)

### Added

- Added a `vendor_deleted_date` field to the `System` model [#10](https://github.com/ethyca/fideslang/pull/10)

## [3.0.0](https://github.com/ethyca/fideslang/compare/2.2.2...3.0.0)

Expand Down
4 changes: 4 additions & 0 deletions src/fideslang/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"""
from __future__ import annotations

from datetime import datetime
from enum import Enum
from typing import Any, Dict, List, Optional, Union

Expand Down Expand Up @@ -946,6 +947,9 @@ class System(FidesModel):
previous_vendor_id: Optional[str] = Field(
description="If specified, the unique identifier for the vendor that was previously associated with this system."
)
vendor_deleted_date: Optional[datetime] = Field(
description="The deleted date of the vendor that's associated with this system."
)
dataset_references: List[FidesKey] = Field(
default_factory=list,
description="Referenced Dataset fides keys used by the system.",
Expand Down
4 changes: 3 additions & 1 deletion tests/fideslang/test_models.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from datetime import datetime

from pytest import mark, raises

from fideslang import DataFlow, Dataset, Organization, PrivacyDeclaration, System
Expand Down Expand Up @@ -371,6 +373,7 @@ def test_expanded_system(self):
)
],
vendor_id="gvl.1",
vendor_deleted_date=datetime.now(),
dataset_references=["test_fides_key_dataset"],
processes_personal_data=True,
exempt_from_privacy_regulations=False,
Expand Down Expand Up @@ -504,4 +507,3 @@ def test_dataset_collection_skip_processing(self):
class TestDataUse:
def test_minimal_data_use(self):
assert DataUse(fides_key="new_use")

0 comments on commit ae88104

Please sign in to comment.