Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KubernetesPodOperator's broken resources arg #118

Closed
wants to merge 1 commit into from

Conversation

eap
Copy link

@eap eap commented May 17, 2021

Since at least airflow version 1.10.4 the kubernetes pod operator resources argument has taken a dictionary rather than the actual resources object. reference docs. This change updates the config to properly set resource constraints.

Without this change, users of the Kubernetes Pod Operator will get the following error in the generated airflow;

TypeError: airflow.kubernetes.pod.Resources() argument after ** must be a mapping, not Resources

@eap eap changed the title get rid of resources preprocessor Get rid of KubernetesPodOperator resources preprocessor May 17, 2021
@eap eap changed the title Get rid of KubernetesPodOperator resources preprocessor Fix KubernetesPodOperator's broken resources arg May 18, 2021
@peleyal
Copy link
Contributor

peleyal commented May 18, 2021

@vchiapaikeo Can you (or someone else in the team) please take a look at this PR?
We will be moving to our own plugin, however there are fixes here and there to the current configuration.
PTAL, thanks!

@vchiapaikeo
Copy link
Contributor

@peleyal , @eap, since we are still on version 1.10.3, we'd like to leave this as is. We are in fact still passing resources through as a dictionary. However, you can make this change to your plugin version and still be able to use it (you'd create an identical version of this config file and it will be prioritized over the boundary-layer version).

@peleyal
Copy link
Contributor

peleyal commented May 21, 2021

Thanks @vchiapaikeo, I finally found some time to create our own plugin. Your documentation in #114 was really useful. Thank you!

@eap
Copy link
Author

eap commented Nov 1, 2021

since we manage our own plugin and this is incompatible with the default plugin. I'm closing this PR

@eap eap closed this Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants