Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate log suppression pr :) #1305

Conversation

bluebandit21
Copy link
Member

Should fix problems of #1304

Note -- in order to prevent acquiring a global mutex between multiple threads, I exploit the fact that a spammed log message would happen on the same thread, letting us use thread_local variables instead.

@poco0317
Copy link
Member

replaced by 82a5e44 because I think the amount of effort going into consolidating log lines has gotten lost in the sauce. it's better for now to restrict log file sizes and be reasonable about the amount of logging we do. if a log file ends up hitting a 64mb cap, then theres obviously a problem and we can look at how that happened in the first place

@poco0317 poco0317 closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants