Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align SD-JWT-VC PID with PID rulebook and include signing key information in SD-JWT-VC header claims #249

Merged
merged 15 commits into from
Nov 25, 2024
Merged

Align SD-JWT-VC PID with PID rulebook and include signing key information in SD-JWT-VC header claims #249

merged 15 commits into from
Nov 25, 2024

Conversation

dzarras
Copy link
Contributor

@dzarras dzarras commented Nov 22, 2024 •
edited
Loading

  1. Fixes some misaligned names
  2. Aligns Display descriptions with PID rulebook
  3. Updates Keycloak realm with new profile fields and mappers to support all PID attributes
  4. Adds missing mappings
  5. Adds populates kid and x5c headers claims with signing key information

Closes #246
Closes #247

@dzarras dzarras requested a review from a team as a code owner November 22, 2024 15:52
@dzarras dzarras requested a review from babisRoutis November 22, 2024 15:52
@babisRoutis babisRoutis added this to the pid-issuer v0.3.2 milestone Nov 22, 2024
babisRoutis
babisRoutis previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@babisRoutis babisRoutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzarras Some minor comments.

src/main/kotlin/eu/europa/ec/eudi/pidissuer/adapter/out/pid/EncodePidInSdJwtVc.kt Outdated Show resolved Hide resolved
src/main/kotlin/eu/europa/ec/eudi/pidissuer/adapter/out/pid/GetPidDataFromAuthServer.kt Outdated Show resolved Hide resolved
src/main/kotlin/eu/europa/ec/eudi/pidissuer/PidIssuerApplication.kt Outdated Show resolved Hide resolved
babisRoutis
babisRoutis previously approved these changes Nov 25, 2024
View reviewed changes
@dzarras dzarras changed the title Align SD-JWT-VC PID with PID rulebook Align SD-JWT-VC PID with PID rulebook and include signing key information in SD-JWT-VC header claims Nov 25, 2024
@dzarras dzarras removed this from the pid-issuer v0.3.2 milestone Nov 25, 2024
@dzarras dzarras merged commit abd357b into eu-digital-identity-wallet:main Nov 25, 2024
3 checks passed
@dzarras dzarras deleted the check/pid-sd-jwt-vc branch November 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babisRoutis babisRoutis babisRoutis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evaluate SD-JWT-VC Issuer Keys resolution to use Check the SD-JWT-VC model for PID
2 participants
@dzarras @babisRoutis