Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebClient updates #37

Merged
merged 1 commit into from
Nov 20, 2023
Merged

WebClient updates #37

merged 1 commit into from
Nov 20, 2023

Conversation

dzarras
Copy link
Contributor

@dzarras dzarras commented Nov 20, 2023

Provide a single WebClient in the application context that is either secure, or insecure depending on the active Spring profile.

@dzarras dzarras added the feature New feature or request label Nov 20, 2023
@dzarras dzarras requested a review from babisRoutis November 20, 2023 13:34
@dzarras dzarras requested a review from a team as a code owner November 20, 2023 13:34
@dzarras
Copy link
Contributor Author

dzarras commented Nov 20, 2023

@babisRoutis Could you please let me know what you think?

Copy link
Contributor

@babisRoutis babisRoutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzarras One thing that I am not sure is whether Spring Security uses this client or not

opaqueToken {}
opaqueToken {
val properties = ref<OAuth2ResourceServerProperties>()
introspector = SpringReactiveOpaqueTokenIntrospector(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babisRoutis By default Spring Security creates its own instance of a WebClient.
Thus we provide a SpringReactiveOpaqueTokenIntrospector instance that uses the WebClient we define as a bean.

@dzarras dzarras requested a review from babisRoutis November 20, 2023 14:31
@babisRoutis babisRoutis merged commit 30c2b3b into eu-digital-identity-wallet:main Nov 20, 2023
@babisRoutis babisRoutis deleted the feature/web-client-updates branch November 20, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants