Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat([asyncapi]): if service version is lower than latest add a servi… #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XaaXaaX
Copy link
Contributor

@XaaXaaX XaaXaaX commented Oct 20, 2024

Motivation

When service version lower than latest are treated after latest is already treated this leads to versioning the latest in versioned and keep the incorrect version as latest.

example:
if a spec for version 2 is treated and later version 1 is treated the latest version will be the v1 and v2 get into the versions folder.

This pull request checks the sequence of versions and treats them in the correct order

@XaaXaaX XaaXaaX requested a review from boyney123 as a code owner October 20, 2024 12:31
Copy link

changeset-bot bot commented Oct 20, 2024

⚠️ No Changeset found

Latest commit: 5fb18aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@XaaXaaX XaaXaaX force-pushed the feat/verify-current-version-vs-latest branch 3 times, most recently from 906b548 to 0add654 Compare October 20, 2024 13:15
@XaaXaaX
Copy link
Contributor Author

XaaXaaX commented Oct 20, 2024

This PR relates to SDK PR event-catalog/sdk#44
By this we will remove hard coded versioned service path here

@XaaXaaX XaaXaaX force-pushed the feat/verify-current-version-vs-latest branch 2 times, most recently from fe8d7d3 to ac5cded Compare October 22, 2024 22:30
@XaaXaaX
Copy link
Contributor Author

XaaXaaX commented Oct 22, 2024

Related to SDK latest release event-catalog/sdk#44
Generator write a service version in versioned folder if under treatment current version in inferior of latest version

@XaaXaaX XaaXaaX force-pushed the feat/verify-current-version-vs-latest branch 4 times, most recently from 4459f87 to 334af3c Compare October 27, 2024 19:18
@XaaXaaX XaaXaaX force-pushed the feat/verify-current-version-vs-latest branch from 334af3c to 5fb18aa Compare October 27, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants