Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat([asyncapi]): keep latest service version in domain services ma… #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XaaXaaX
Copy link
Contributor

@XaaXaaX XaaXaaX commented Oct 26, 2024

Motivation

The domain markdown actually contains multiple versions of same service, leading to duplication in visualizer and makes it hard to use, the PR deduplicates the service list by name and keep the new version

@XaaXaaX XaaXaaX requested a review from boyney123 as a code owner October 26, 2024 00:28
Copy link

changeset-bot bot commented Oct 26, 2024

⚠️ No Changeset found

Latest commit: 1ca9c82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@XaaXaaX XaaXaaX force-pushed the feat/deduplicate-services-in-domain branch from 8228cf4 to f7e1a61 Compare October 26, 2024 00:29
@XaaXaaX XaaXaaX force-pushed the feat/deduplicate-services-in-domain branch from f7e1a61 to 1ca9c82 Compare October 27, 2024 19:10
@boyney123
Copy link
Contributor

Hey @XaaXaaX thanks for raising this.

Curious, How can I replicate the bug?

@boyney123 boyney123 added the question Further information is requested label Nov 25, 2024
@XaaXaaX
Copy link
Contributor Author

XaaXaaX commented Nov 25, 2024

Hey @XaaXaaX thanks for raising this.

Curious, How can I replicate the bug?

@boyney123
Enough , for example, have a domain markdown containing version 1.0.0 for simple-service and add a version 2.0.0 for the same service using generator

The domain will contain both at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants