Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-10799] drop support for node 14 #304

Merged
merged 2 commits into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v1
with:
node-version: 18
node-version: 20
- name: Setup ncc
run: npm install -g @vercel/ncc
- run: yarn install --frozen-lockfile --check-files
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
with:
registry-url: 'https://registry.npmjs.org/'
scope: 'expo'
node-version: 18
node-version: 20
- name: Setup ncc
run: npm install -g @vercel/ncc
- name: Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ on:
jobs:
test:
runs-on: macos-latest
name: Test with Node 18 on macOS
name: Test with Node 20 on macOS
steps:
- uses: actions/checkout@v2
- name: Setup node
uses: actions/setup-node@v1
with:
node-version: 18
node-version: 20
- name: Setup ncc
run: npm install -g @vercel/ncc
- run: yarn install --frozen-lockfile --check-files
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: ['14', '16', '18']
node: ['16', '18', '20']
name: Test with Node ${{ matrix.node }} on Linux
steps:
- uses: actions/checkout@v2
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
"release": "./scripts/release.sh"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"devDependencies": {
"@types/node": "^18.11.18",
"@types/node": "20.11.0",
"eslint": "^8.46.0",
"eslint-config-universe": "^11.3.0",
"eslint-plugin-import": "^2.28.0",
Expand All @@ -28,7 +28,7 @@
"packages/*"
],
"volta": {
"node": "18.13.0",
"yarn": "1.22.19"
"node": "20.11.0",
"yarn": "1.22.21"
}
}
6 changes: 3 additions & 3 deletions packages/build-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@types/fs-extra": "^11.0.1",
"@types/jest": "^29.5.3",
"@types/lodash": "^4.14.196",
"@types/node": "^18.11.18",
"@types/node": "20.11.0",
"@types/node-forge": "^1.3.1",
"@types/plist": "^3.0.2",
"@types/semver": "^7.5.0",
Expand All @@ -63,7 +63,7 @@
"uuid": "^9.0.0"
},
"volta": {
"node": "18.13.0",
"yarn": "1.22.19"
"node": "20.11.0",
"yarn": "1.22.21"
}
}
6 changes: 3 additions & 3 deletions packages/create-eas-build-function/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@expo/package-manager": "^1.0.2",
"@jest/globals": "^29.6.2",
"@types/jest": "^29.5.3",
"@types/node": "^18.11.18",
"@types/node": "20.11.0",
"@types/prompts": "^2.4.4",
"@vercel/ncc": "^0.38.0",
"chalk": "4.1.2",
Expand All @@ -54,7 +54,7 @@
"access": "public"
},
"volta": {
"node": "18.13.0",
"yarn": "1.22.19"
"node": "20.11.0",
"yarn": "1.22.21"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"keywords": [],
"author": "",
"devDependencies": {
"@types/node": "^18.11.18",
"@types/node": "20.11.0",
"typescript": "^5.1.6",
"@expo/steps": "^1.0.34"
}
Expand Down
6 changes: 3 additions & 3 deletions packages/downloader/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@
"devDependencies": {
"@types/fs-extra": "^11.0.1",
"@types/jest": "^29.5.3",
"@types/node": "^18.11.18",
"@types/node": "20.11.0",
"jest": "^29.6.2",
"ts-jest": "^29.1.1",
"typescript": "^5.1.6"
},
"volta": {
"node": "18.13.0",
"yarn": "1.22.19"
"node": "20.11.0",
"yarn": "1.22.21"
}
}
6 changes: 3 additions & 3 deletions packages/eas-build-job/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"license": "MIT",
"devDependencies": {
"@types/jest": "^29.5.3",
"@types/node": "^18.11.18",
"@types/node": "20.11.0",
"jest": "^29.6.2",
"ts-jest": "^29.1.1",
"typescript": "^5.1.6"
Expand All @@ -30,7 +30,7 @@
"semver": "^7.5.4"
},
"volta": {
"node": "18.13.0",
"yarn": "1.22.19"
"node": "20.11.0",
"yarn": "1.22.21"
}
}
6 changes: 3 additions & 3 deletions packages/local-build-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"clean": "rm -rf node_modules dist coverage"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"author": "Expo <support@expo.io>",
"bugs": "https://github.com/expo/eas-build/issues",
Expand Down Expand Up @@ -52,7 +52,7 @@
"typescript": "^5.1.6"
},
"volta": {
"node": "18.13.0",
"yarn": "1.22.19"
"node": "20.11.0",
"yarn": "1.22.21"
}
}
6 changes: 3 additions & 3 deletions packages/logger/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@
},
"devDependencies": {
"@types/jest": "^29.5.3",
"@types/node": "^18.11.18",
"@types/node": "20.11.0",
"jest": "^29.6.2",
"ts-jest": "^29.1.1",
"typescript": "^5.1.6"
},
"volta": {
"node": "18.13.0",
"yarn": "1.22.19"
"node": "20.11.0",
"yarn": "1.22.21"
}
}
8 changes: 4 additions & 4 deletions packages/steps/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@types/jest": "^29.5.3",
"@types/lodash.clonedeep": "^4.5.7",
"@types/lodash.get": "^4.4.7",
"@types/node": "^18.11.18",
"@types/node": "20.11.0",
"chokidar-cli": "^3.0.0",
"eslint-plugin-async-protect": "^3.0.0",
"jest": "^29.6.2",
Expand All @@ -45,7 +45,7 @@
"typescript": "^5.1.6"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"dependencies": {
"@expo/logger": "1.0.52",
Expand All @@ -60,7 +60,7 @@
"yaml": "^2.3.1"
},
"volta": {
"node": "18.13.0",
"yarn": "1.22.19"
"node": "20.11.0",
"yarn": "1.22.21"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"author": "",
"license": "ISC",
"devDependencies": {
"@types/node": "^20.4.1",
"@types/node": "20.11.0",
"typescript": "^5.1.6"
},
"dependencies": {
Expand Down
6 changes: 3 additions & 3 deletions packages/template-file/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@
"@types/jest": "^29.5.3",
"@types/lodash": "^4.14.196",
"@types/lodash.template": "^4.5.1",
"@types/node": "^18.11.18",
"@types/node": "20.11.0",
"jest": "^29.6.2",
"ts-jest": "^29.1.1",
"typescript": "^5.1.6"
},
"volta": {
"node": "18.13.0",
"yarn": "1.22.19"
"node": "20.11.0",
"yarn": "1.22.21"
}
}
6 changes: 3 additions & 3 deletions packages/turtle-spawn/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@
},
"devDependencies": {
"@types/jest": "^29.5.3",
"@types/node": "^18.11.18",
"@types/node": "20.11.0",
"jest": "^29.6.2",
"ts-jest": "^29.1.1",
"typescript": "^5.1.6"
},
"volta": {
"node": "18.13.0",
"yarn": "1.22.19"
"node": "20.11.0",
"yarn": "1.22.21"
}
}
15 changes: 11 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1730,10 +1730,12 @@
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.37.tgz#a3dd8da4eb84a996c36e331df98d82abd76b516e"
integrity sha512-XYmBiy+ohOR4Lh5jE379fV2IU+6Jn4g5qASinhitfyO71b/sCo6MKsMLF5tc7Zf2CE8hViVQyYSobJNke8OvUw==

"@types/node@^18.11.18":
version "18.11.18"
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.11.18.tgz#8dfb97f0da23c2293e554c5a50d61ef134d7697f"
integrity sha512-DHQpWGjyQKSHj3ebjFI/wRKcqQcdR+MoFBygntYOZytCqNfkd2ZC4ARDJ2DQqhjH5p85Nnd3jhUJIXrszFX/JA==
"@types/node@20.11.0":
version "20.11.0"
resolved "https://registry.yarnpkg.com/@types/node/-/node-20.11.0.tgz#8e0b99e70c0c1ade1a86c4a282f7b7ef87c9552f"
integrity sha512-o9bjXmDNcF7GbM4CNQpmi+TutCgap/K3w1JyKgxAjqx41zp9qlIAVFi0IhCNsJcXolEqLWhbFbEeL0PvYm4pcQ==
dependencies:
undici-types "~5.26.4"

"@types/normalize-package-data@^2.4.0":
version "2.4.0"
Expand Down Expand Up @@ -8549,6 +8551,11 @@ unbox-primitive@^1.0.2:
has-symbols "^1.0.3"
which-boxed-primitive "^1.0.2"

undici-types@~5.26.4:
version "5.26.5"
resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-5.26.5.tgz#bcd539893d00b56e964fd2657a4866b221a65617"
integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==

unique-filename@^2.0.0:
version "2.0.1"
resolved "https://registry.yarnpkg.com/unique-filename/-/unique-filename-2.0.1.tgz#e785f8675a9a7589e0ac77e0b5c34d2eaeac6da2"
Expand Down
Loading