Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fcmv1] Manage FCM V1 Google Service Account Key in CLI #2197

Merged
merged 2 commits into from
Feb 7, 2024
+360 −58

update CHANGELOG.md

66452b9
Select commit
Loading
Failed to load commit list.
Merged

[fcmv1] Manage FCM V1 Google Service Account Key in CLI #2197

update CHANGELOG.md
66452b9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 7, 2024 in 0s

54.08% (-0.08%) compared to 0b71812

View this Pull Request on Codecov

54.08% (-0.08%) compared to 0b71812

Details

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (0b71812) 54.16% compared to head (66452b9) 54.08%.

Files Patch % Lines
...id/actions/SetUpGoogleServiceAccountKeyForFcmV1.ts 24.25% 22 Missing and 3 partials ⚠️
...s/eas-cli/src/credentials/manager/ManageAndroid.ts 16.67% 19 Missing and 1 partial ⚠️
...d/actions/AssignGoogleServiceAccountKeyForFcmV1.ts 25.00% 6 Missing ⚠️
...graphql/mutations/AndroidAppCredentialsMutation.ts 0.00% 4 Missing ⚠️
.../src/credentials/android/utils/printCredentials.ts 75.00% 3 Missing ⚠️
...s-cli/src/credentials/android/api/GraphqlClient.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
- Coverage   54.16%   54.08%   -0.08%     
==========================================
  Files         516      518       +2     
  Lines       18814    18894      +80     
  Branches     3969     3984      +15     
==========================================
+ Hits        10188    10216      +28     
- Misses       7934     7981      +47     
- Partials      692      697       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov