Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(eas-cli): expose expo export dev flag as an option in eas update (#2050)" #2214

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Feb 6, 2024

Why

This reverts commit 8751a28.

The reason we're reverting this is that it is causing some confusion around whether dev bundles work with EAS update. The answer is that they probably shouldn't, or at least aren't officially supported.

"Dev" bundles are quite different from production bundles (no minification, possibly different Babel presets running, different NODE_ENV is set, and __DEV__ value is different). The value of __DEV__ is used in many places to change behavior to fit a development environment, for example in expo-asset. If we want to support loading updates that are published in dev mode, we should ensure we have adequate test coverage and that this is something we are consciously supporting.

Instead, to address the original concern in #2050 (accessing the dev menu), we'll address that issue in a more targeted manner: by making accessing the dev menu even in places when __DEV__ isn't set.

Alternatively, one could theoretically do the export step manually during an eas update by running the npx expo export command manually and then running eas update --skip-bundler.

Closes ENG-11290.

How

Revert.

Test Plan

CI

Copy link

github-actions bot commented Feb 6, 2024

Size Change: -171 kB (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB -171 kB (0%)

compressed-size-action

Copy link

linear bot commented Feb 6, 2024

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69b0eda) 54.16% compared to head (9cca0dd) 54.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2214      +/-   ##
==========================================
+ Coverage   54.16%   54.17%   +0.02%     
==========================================
  Files         516      516              
  Lines       18814    18810       -4     
  Branches     3969     3965       -4     
==========================================
  Hits        10188    10188              
+ Misses       7934     7930       -4     
  Partials      692      692              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman
Copy link
Member Author

/changelog-entry bug-fix Revert expose expo export dev flag as an option in eas update

@wschurman wschurman merged commit 2e49f63 into main Feb 8, 2024
5 checks passed
@wschurman wschurman deleted the @wschurman/revert-dev-flag branch February 8, 2024 20:38
Copy link

github-actions bot commented Feb 8, 2024

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants