[eas-cli] fix git diff header in fingerprint:compare #2915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The current git-style diff output in the fingerprint diff utility shows incorrect line numbers in the chunk headers. This affects the readability and accuracy of diff representations when comparing fingerprints.
How
Updated the chunk header calculation in
fingerprintDiff.ts
to properly account for context lines when determining the line ranges. The fix adjusts both the starting position and total line count by incorporating the context lines in the calculations.The changes ensure that:
Test Plan
EXPO_STAGING=1 ~/Documents/eas-cli/packages/eas-cli/bin/run fingerprint:compare 796b89315aeaa4b466aa3ac6c2dcff5cf9ed4c8e d5de1b929c0346251e400eed13205fda4eaf51bf
and ensure diff header is correct