[eas-cli] Fix .git x .easignore interaction

[sjchmiela]

Why

Thanks to a conversation on Bluesky it turned out this check is invalid (always true), because Ignore has DEFAULT_IGNORE, so even if a user had no .git in .easignore, especially if they had requireCommit: true, .git would be removed.

How

• Added a check to disallow .easignore if one has requireCommit: true.
• Changed logic around Ignore so we have separate createForCopying (ignores .git and node_modules always) and createForChecking (does not ignore anything by default). I don't like it, but it should work and is the best of what I could come up with without further refactoring.

Test Plan

Added more tests.

[github-actions]

Size Change: -3.94 kB (-0.01%)

Total Size: 53.4 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	53.4 MB	-3.94 kB (-0.01%)

_{compressed-size-action}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.66%. Comparing base (2790fd4) to head (f074dc8).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2925      +/-   ##
==========================================
+ Coverage   52.64%   52.66%   +0.03%     
==========================================
  Files         588      588              
  Lines       23203    23210       +7     
  Branches     4613     4614       +1     
==========================================
+ Hits        12212    12221       +9     
+ Misses      10957    10955       -2     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

✅ Thank you for adding the changelog entry!

[github-actions]

Subscribed to pull request

File Patterns	Mentions
**/*	@szdziedzic, @khamilowicz, @radoslawkrzemien

Generated by CodeMention

[szdziedzic]

looks ok

[thespacemanatee]

@sjchmiela this is a breaking change for us and it is not apparent at first glance how to fix this issue. We have requireCommit=true because of EAS Workflows and .easignore to prevent some irrelevant files from being uploaded during eas build.

[sjchmiela]

Based on http://expo.fyi/eas-build-archive .easignore should never have been used if requireCommit=true, so my perspective was v15 introduced a bug which this fixed.

Main purpose of requireCommit is to ensure eas build and running a build from GitHub works the same. We can't adhere to .easignore when running from GitHub.

[sjchmiela]

Is it possible in v14 .easignore wasn't being used at all?

[thespacemanatee]

Is it possible in v14 .easignore wasn't being used at all?

I was on 15.0.12, bumped to 15.0.13 and started getting this error so had to revert.

[sjchmiela]

Ohh, I see what you're saying — "if a release requires me to change stuff in my code to proceed, it's a breaking change". I get that.

What I was going for was "hey guys this .easignore you have in your workspace is doing nothing, just remove it because you may be thinking it's doing something and it's not". Sorry.

Let me write out how I things played out:

• in eas-cli@<15 requireCommit: true allowed existence of .easignore, but ignored it (is this a clear behavior? I don't think so.)
• in eas-cli@15.0.0 requireComit: true not only allowed existence of .easignore, but started removing files based on it. This was an unwanted breaking change and a bug.
• in eas-cli@15.0.13 requireCommit: true disallowed existence of .easignore hoping to make the behavior clearer.

What do you think is the best course of action here now?